-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use wmlscope
to find and remove unused code/assets
#57
Comments
see also bug #20 |
oh let's use this for duplicate resources, too; here's my current
|
current "unused" report:
|
#62 only addresses stuff that was ifdef-ed out; it doesn't address the full current |
remove unused macro; see nemaara/A_New_Order#57
Update: @Toranks noted this one on Discord, too |
according to https://forums.wesnoth.org/viewtopic.php?p=682436#p682436, |
- new linting workflow - recompression of images - start of work on some lua - validator fixes - updated README see the following issues: - #7 - #32 - #33, checkbox 2 - #57 (a bit) - nemaara#73 (gets started with it at least; I'm holding back on some other parts I've written for it until they're more submittable) - nemaara#81 (adds FIXMEs about it) - nemaara#144
I'm kinda waiting until wesnoth/wesnoth#6755 is fixed so I can sort out which ones need prioritizing a bit better |
...uh oh, I might have discovered a bug with
|
ok so I removed a bunch of unused assets in #215, but there's still the code half of this... |
opened wesnoth/wesnoth#9259 for the |
...also, it turns out that some of the removals that I did in #215 may have been wrong, but I probably won't want to put them back until czyzby/wesnoth-png-optimizer#7 is fixed... |
it was unused and confusing at least 1 translator; see issue #57
one thing @knyghtmare complained about recently was how big the download was, well a lot of that comes from there being a bunch of old cruft leftover in the repo. We should use
wmlscope
to find stuff that's unused, and then either actually use it (as I plan to do withabilities.cfg
as per #55), or just remove it.The text was updated successfully, but these errors were encountered: