start compiling editor #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix printf-like function calls * move platform_interface.cpp to 'pc' folder * fix linking lua * fix stb int typedefs
| @@ -302,7 +302,7 @@ bool AssetBrowser::resourceInput(const char* label, const char* str_id, char* bu | |||
| m_wanted_resource = buf; | |||
| } | |||
| ImGui::SameLine(); | |||
| ImGui::Text(label); | |||
| ImGui::Text("%s", label); | |||
There was a problem hiding this comment.
gcc can check string format strings and arguments and gives warning (which becomes error with -Werror)
../../../src/editor/asset_browser.cpp: In member function ‘bool AssetBrowser::resourceInput(const char*, const char*, char*, int, Lumix::uint32)’:
../../../src/editor/asset_browser.cpp:305:19: error: format not a string literal and no format arguments [-Werror=format-security]
ImGui::Text(label);
^
cc1plus: all warnings being treated as errors
If you pass printf-like function not a string literal but some received string, this function can misinterpret it (suppose this string has %s in it) and read arbitrary memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #655