Linux port WIP #811
Merged
Linux port WIP #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,16 +87,19 @@ function defaultConfigurations() | |||
| configuration "Debug" | |||
| targetdir(BINARY_DIR .. "Debug") | |||
| defines { "DEBUG" } | |||
| buildoptions { "-std=c++11" } | |||
There was a problem hiding this comment.
I'm not very sure about these options on MSVS in particular and about build configuration for Linux in general.
There was a problem hiding this comment.
I tried to compile it with MSVS, and even though -std=c++11 is ignored, it causes warnings
2>cl : Command line warning D9002: ignoring unknown option '-std=c++11'
There was a problem hiding this comment.
OK, I'm removing it for now.
|
I guess it is better to do it iteratively, github has problems with large PR anyway. There is just one issue before this can be merged, see my comment about |
|
Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to do it iteratively instead of having one huge PR. Please, take a look.