Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2403): deprecation warning in symfony 7.2 when using "tagged" type in service configuration #2405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

W0rma
Copy link

@W0rma W0rma commented Dec 4, 2024

Description

tagged_iterator is already available in Symfony 5.4 (https://symfony.com/doc/5.x/service_container/tags.html#reference-tagged-services).
Therefore, the deprecated type tagged can just be replaced with tagged_iterator.

Closes #2403

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@W0rma W0rma changed the title Symfony 7.2: Fix deprecation warning usage of "tagged" type which is deprecated in symfony 7.2 Symfony 7.2: Fix deprecation warning usage of "tagged" type Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (9411e9c) to head (9a78d09).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2405   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files          78       78           
  Lines        2896     2896           
=======================================
  Hits         2592     2592           
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@W0rma W0rma changed the title Symfony 7.2: Fix deprecation warning usage of "tagged" type (fix #2403): deprecation warning in symfony 7.2 when using "tagged" type in service configuration Dec 4, 2024
@W0rma W0rma changed the title (fix #2403): deprecation warning in symfony 7.2 when using "tagged" type in service configuration fix(#2403): deprecation warning in symfony 7.2 when using "tagged" type in service configuration Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Symfony 7.2 - deprecation type "tagged"
1 participant