Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect directory used for updated swagger-ui #2379

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

DjordyKoert
Copy link
Collaborator

Description

Fixes incorrect directory used for updated swagger-ui files introduced in #2378

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@DjordyKoert DjordyKoert merged commit 9d74fa9 into master Nov 7, 2024
17 checks passed
@DjordyKoert DjordyKoert deleted the fix-2378-pr-merge branch November 7, 2024 09:50
DjordyKoert added a commit that referenced this pull request Nov 7, 2024
## Description

Fixes incorrect directory used for updated swagger-ui files introduced
in #2378

## What type of PR is this? (check all applicable)
- [x] Bug Fix
- [ ] Feature
- [ ] Refactor
- [ ] Deprecation
- [ ] Breaking Change
- [ ] Documentation Update
- [ ] CI

## Checklist
- [ ] I have made corresponding changes to the documentation (`docs/`)
- [ ] I have made corresponding changes to the changelog
(`CHANGELOG.md`)

(cherry picked from commit 9d74fa9)
@s3tezsky
Copy link
Contributor

s3tezsky commented Nov 7, 2024

Hi again!

I have just noticed there was some updates necessery after merging previous PR (#2378)

The wrong path of original fix was casued by update script:

dest=Resources/public/swagger-ui/

Is the script correct? or should it be updated too?

@DjordyKoert
Copy link
Collaborator Author

Hi again!

I have just noticed there was some updates necessery after merging previous PR (#2378)

The wrong path of original fix was casued by update script:

dest=Resources/public/swagger-ui/

Is the script correct? or should it be updated too?

The script is incorrect :/

DjordyKoert added a commit that referenced this pull request Nov 7, 2024
## Description


#2379 (comment)

## What type of PR is this? (check all applicable)
- [ ] Bug Fix
- [ ] Feature
- [ ] Refactor
- [ ] Deprecation
- [ ] Breaking Change
- [ ] Documentation Update
- [ ] CI

## Checklist
- [ ] I have made corresponding changes to the documentation (`docs/`)
- [ ] I have made corresponding changes to the changelog
(`CHANGELOG.md`)
DjordyKoert added a commit that referenced this pull request Nov 7, 2024
## Description

#2379 (comment)

## What type of PR is this? (check all applicable)
- [ ] Bug Fix
- [ ] Feature
- [ ] Refactor
- [ ] Deprecation
- [ ] Breaking Change
- [ ] Documentation Update
- [ ] CI

## Checklist
- [ ] I have made corresponding changes to the documentation (`docs/`)
- [ ] I have made corresponding changes to the changelog
(`CHANGELOG.md`)

(cherry picked from commit f981465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants