refactor: remove deprecation & thrown exception & constructor defaults #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DjordyKoert
force-pushed
the
refactor-FormModelDescriber
branch
from
b755c15 to
c9432e2
Compare
DjordyKoert
force-pushed
the
refactor-FormModelDescriber
branch
from
c9432e2 to
8e0df09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
==========================================
+ Coverage 89.37% 89.46% +0.08%
==========================================
Files 77 77
Lines 2853 2848 -5
==========================================
- Hits 2550 2548 -2
+ Misses 303 300 -3 ☔ View full report in Codecov by Sentry. |
DjordyKoert
added a commit
that referenced
this pull request
Nov 7, 2024
#2375) ## Description Refactor `FormModelDescriber`: - Remove default values from constructor params - The class is marked as internal so default params are not needed as we can rely on DI - Removed impossible deprecation `$mediaTypes` is not nullable - Removed impossible exception `$formFactory` could never be `null` ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [x] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [x] I have made corresponding changes to the documentation (`docs/`) - [x] I have made corresponding changes to the changelog (`CHANGELOG.md`) (cherry picked from commit 1023c9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
FormModelDescriber:$mediaTypesis not nullable$formFactorycould never benullWhat type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)