Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4.x annotation to attribute migration 5.x #2369

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

DjordyKoert
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
Deprecations? yes

Migration for annotations to attributes #2368 (comment)

@DjordyKoert DjordyKoert changed the title 4.x attribute migration 5.x deprecation: 4.x annotation to attribute migration 5.x Oct 25, 2024
@DjordyKoert DjordyKoert changed the title deprecation: 4.x annotation to attribute migration 5.x feat: 4.x annotation to attribute migration 5.x Oct 25, 2024
@DjordyKoert DjordyKoert force-pushed the 4.x-attribute-migration-5.x branch from c2daf9b to 2b0405f Compare October 25, 2024 13:09
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (4cc45e8) to head (dba4732).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Attribute/Areas.php 85.71% 2 Missing ⚠️
src/Annotation/Operation.php 0.00% 1 Missing ⚠️
src/Routing/FilteredRouteCollectionBuilder.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
- Coverage   89.36%   89.35%   -0.02%     
==========================================
  Files          73       77       +4     
  Lines        2841     2846       +5     
==========================================
+ Hits         2539     2543       +4     
- Misses        302      303       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert force-pushed the 4.x-attribute-migration-5.x branch from e98b927 to ff8e4ce Compare October 25, 2024 13:33
@DjordyKoert DjordyKoert merged commit c0a4aee into master Oct 25, 2024
31 of 33 checks passed
@DjordyKoert DjordyKoert deleted the 4.x-attribute-migration-5.x branch October 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant