Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple authorisations to be stored and restored #2311

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

bobvandevijver
Copy link
Contributor

@bobvandevijver bobvandevijver commented Jul 9, 2024

Q A
Bug fix? maybe
New feature? maybe
Deprecations? no
Issues -

I have an API description which has multiple authorisation options, which is supported fine by the Swagger interfaces. However, the store/restore functionality always overrides the previous stored value, so only the last input is restored on page load. This change solves that.

As far as I know everything I used should work fine on relevant browsers.

I do not believe that the build failures are related to this PR....

@bobvandevijver bobvandevijver changed the title Support multiple authorisations to be stored and restored feat: Support multiple authorisations to be stored and restored Jul 9, 2024
@bobvandevijver bobvandevijver changed the title feat: Support multiple authorisations to be stored and restored feat: support multiple authorisations to be stored and restored Jul 9, 2024
@bobvandevijver
Copy link
Contributor Author

@DjordyKoert Anything I can do to get this merged?

@DjordyKoert
Copy link
Collaborator

Sorry for the late response.

It's generally quite cumbersome to test / validate that any changes to the javascript code will function 😢

@DjordyKoert DjordyKoert merged commit be67a3a into nelmio:master Oct 17, 2024
15 checks passed
@DjordyKoert
Copy link
Collaborator

Thank you for the contribution at least ❤️

@bobvandevijver bobvandevijver deleted the patch-1 branch October 18, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants