Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING guide #2261

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update CONTRIBUTING guide #2261

merged 2 commits into from
Apr 11, 2024

Conversation

DominicLuidold
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Issues /

Rewrites the contributing guide to incorporate recent developments and brings it up to date:

DjordyKoert
DjordyKoert requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@DjordyKoert DjordyKoert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much (once again 😄)

A few remarks but everything else looks good 👍

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@DominicLuidold @DjordyKoert
Implement PR review feedback
1e93d4f 
Co-authored-by: Djordy Koert <[email protected]>
@DjordyKoert DjordyKoert merged commit 29e90a2 into nelmio:master Apr 11, 2024
12 checks passed
@DjordyKoert
Copy link
Collaborator

thank you @DominicLuidold ❤️

@DominicLuidold DominicLuidold mentioned this pull request Apr 12, 2024
Closed
@DominicLuidold DominicLuidold deleted the contributing-rewrite branch June 23, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjordyKoert DjordyKoert DjordyKoert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominicLuidold @DjordyKoert