-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added symfony/uuid property describer #2098
Conversation
I would also like to see some tests for this |
I'll try to add some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stollr Any help needed with implementing test cases for this? 😃
@DominicLuidold I have rebased the PR to current master. But running the tests, I get
Any idea how to fix this? Update: |
@stollr Let me know if I can help in any other way 😄 |
e5f22fb
to
3cd85c0
Compare
@DominicLuidold I have added a functional and some unit tests and hope it is correct the way I did it. |
with support for symfony/uid and ramsey/uuid
…AbstractUid class
@DjordyKoert I have addressed all comments and rebased the PR on master. I hope it is ready for merge, now :-) |
Thanks I will try and have a look next week :) |
# Conflicts: # composer.json
It took a bit, but it's now merged 😅 Thank you @stollr! |
You're welcome. Thanks for merging |
This describer adds support for UUIDs from the following libraries: symfony/uid and ramsey/uuid
This makes types of these classes configured as
This is based on the spec.