Skip to content

Commit

Permalink
Migrate wordPressUtils to Version Catalog
Browse files Browse the repository at this point in the history
  • Loading branch information
neeldoshii committed Jul 10, 2024
1 parent b47b855 commit a21a674
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 7 deletions.
6 changes: 4 additions & 2 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,11 @@ dependencies {
exclude group: 'org.wordpress', module: 'utils'
exclude group: 'com.android.support', module: 'support-annotations'
}
implementation ("$gradle.ext.wputilsBinaryPath:$wordPressUtilsVersion") {
// TODO: Migrate from composite build path modules to version catalogs (libs.version.toml).
// noinspection UseTomlInstead
implementation ("$gradle.ext.wputilsBinaryPath:${libs.versions.wordPressUtils.get()}") {
version {
strictly wordPressUtilsVersion
strictly libs.versions.wordPressUtils.get()
}
}
implementation ("$gradle.ext.loginFlowBinaryPath:$wordPressLoginVersion") {
Expand Down
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ ext {
wordPressAztecVersion = 'v2.1.3'
wordPressFluxCVersion = 'trunk-79f2bc35285748c715e00f2a6648ed6831632178'
wordPressLoginVersion = '1.16.0'
wordPressUtilsVersion = '3.14.0'
gravatarVersion = '1.0.0'
}

Expand Down
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ volley = '1.2.1'
wiremock = '2.26.3'
wiremockHttpClient = '4.3.5.1'
wordPressPersistentEditText = '1.0.2'
wordPressUtils = '3.14.0'
wordressLint = '2.1.0'
zendesk = '5.1.2'

Expand Down Expand Up @@ -216,6 +217,7 @@ wiremock = { group = "com.github.tomakehurst", name = "wiremock", version.ref ="
wiremock-httpclient-android = { group = "org.apache.httpcomponents", name = "httpclient-android", version.ref ="wiremockHttpClient" }
wordpress-lint = { group = "org.wordpress", name = "lint", version.ref = "wordressLint" }
wordPress-persistentEditText = { group = "org.wordpress", name = "persistentedittext", version.ref = "wordPressPersistentEditText" }
wordpress-utils = { group = "org.wordpress", name = "utils", version.ref = "wordPressUtils" }
zendesk = { group = "com.zendesk", name = "support", version.ref ="zendesk" }

[plugins]
Expand Down
2 changes: 1 addition & 1 deletion libs/analytics/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repositories {

dependencies {
implementation "com.automattic:Automattic-Tracks-Android:$automatticTracksVersion"
implementation "org.wordpress:utils:$wordPressUtilsVersion"
implementation libs.wordpress.utils

implementation libs.androidx.preference

Expand Down
4 changes: 2 additions & 2 deletions libs/editor/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ android {
dependencies {
implementation ("$gradle.ext.wputilsBinaryPath") {
version {
strictly wordPressUtilsVersion
strictly libs.versions.wordPressUtils.get()
}
}
api ("$gradle.ext.aztecAndroidAztecPath") {
Expand Down Expand Up @@ -94,7 +94,7 @@ dependencies {
exclude module: 'react-android'
}

implementation "org.wordpress:utils:$wordPressUtilsVersion"
implementation libs.wordpress.utils

implementation libs.androidx.lifecycle.common
implementation libs.androidx.lifecycle.runtime
Expand Down
2 changes: 1 addition & 1 deletion libs/networking/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies {
implementation (libs.automattic.rest) {
exclude group: 'com.mcxiaoke.volley'
}
implementation "org.wordpress:utils:$wordPressUtilsVersion"
implementation libs.wordpress.utils

implementation libs.volley
implementation libs.androidx.annotation
Expand Down

0 comments on commit a21a674

Please sign in to comment.