-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate: annotate missing branches with "~" #676
Open
blueyed
wants to merge
1
commit into
nedbat:master
Choose a base branch
from
blueyed:annotate-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Licensed under the Apache License: http://www.apache.org/licenses/LICENSE-2.0 | ||
# For details: https://bitbucket.org/ned/coveragepy/src/default/NOTICE.txt | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You'll need to correct the NOTICE links to GitHub to get the tests to pass. |
||
|
||
# A test case sent to me by Steve White | ||
|
||
> def f(self): | ||
! if self==1: | ||
! pass | ||
! elif self.m('fred'): | ||
! pass | ||
! elif (g==1) and (b==2): | ||
! pass | ||
! elif self.m('fred')==True: | ||
! pass | ||
! elif ((g==1) and (b==2))==True: | ||
! pass | ||
! else: | ||
! pass | ||
|
||
> def g(x): | ||
~ if x == 1: | ||
> a = 1 | ||
! else: | ||
! a = 2 | ||
|
||
> g(1) | ||
|
||
> def h(x): | ||
- if 0: #pragma: no cover | ||
- pass | ||
~ if x == 1: | ||
! a = 1 | ||
> else: | ||
> a = 2 | ||
|
||
> h(2) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Licensed under the Apache License: http://www.apache.org/licenses/LICENSE-2.0 | ||
# For details: https://bitbucket.org/ned/coveragepy/src/default/NOTICE.txt | ||
|
||
from tests.test_farm import clean, compare, copy, run | ||
|
||
copy("src", "out") | ||
run(""" | ||
coverage run --branch white.py | ||
coverage annotate white.py | ||
""", rundir="out") | ||
compare("out", "gold_branch", "*,cover") | ||
clean("out") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to sort this, since we're just using
in
on it. Making it a set would be better. Same forexcluded
, though that was my fault! :)statements
andmissing
need to be sorted because of how the algorithm walks them in tandem.