Skip to content

Commit

Permalink
shell: minor tidy up of bash_profile
Browse files Browse the repository at this point in the history
  • Loading branch information
@necolas
necolas committed Nov 25, 2013
1 parent 6809288 commit b866ad8
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions shell/bash_profile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@

# bash_profile

# set 256 color profile where possible
if [[ $COLORTERM == gnome-* && $TERM == xterm ]] && infocmp gnome-256color >/dev/null 2>&1; then

This comment has been minimized.

Sign in to view

Copy link
@iamnewton

iamnewton Feb 9, 2014

Have you read http://blog.sanctum.geek.nz/term-strings/ and what are you're thoughts about $TERM strings being forced in bash. Clearly you support it, but wondering if you've ever run into issues where forcing the $TERM string has had adverse effects.

This comment has been minimized.

Sign in to view

Copy link
@necolas

necolas Feb 9, 2014

Author Owner

I dont have any thoughts on it. If you want open an issue, it will be easier to track.

This comment has been minimized.

Sign in to view

Copy link
@iamnewton

iamnewton Feb 9, 2014

Opened #32 as my old user. But I'm watching the issue so let the discussion begin.
export TERM=gnome-256color
elif infocmp xterm-256color >/dev/null 2>&1; then
export TERM=xterm-256color
fi

# Up-front dotfiles configuration
# Not part of `load_dotfiles` because it `brew` must be available before
# `$(brew --prefix)` is used anywhere.
# Not part of `load_dotfiles` because it must be sourced before anything else
# to be sure that commands like `brew` (when installed in a custom location)
# are already added to the PATH.
[ -r $HOME/.dotfilesrc ] && source $HOME/.dotfilesrc;

load_dotfiles() {
Expand All @@ -29,12 +37,5 @@ load_dotfiles() {
done
}

# set 256 color profile where possible
if [[ $COLORTERM == gnome-* && $TERM == xterm ]] && infocmp gnome-256color >/dev/null 2>&1; then
export TERM=gnome-256color
elif infocmp xterm-256color >/dev/null 2>&1; then
export TERM=xterm-256color
fi

load_dotfiles
unset load_dotfiles

0 comments on commit b866ad8

Please sign in to comment.