[WIP] Refactor shipping_manifest on Spree::Shipment and Spree::Carton

api/app/views/spree/api/shipments/_small.json.jbuilder

@@ -23,7 +23,7 @@ json.cache! [I18n.locale, shipment] do
       json.(shipping_category, :id, :name)
     end
   end
-  json.manifest(shipment.manifest) do |manifest_item|
+  json.manifest(shipment.shipping_manifest_items) do |manifest_item|
     json.variant_id manifest_item.variant.id
     json.quantity(manifest_item.quantity)
     json.states(manifest_item.states)

api/app/views/spree/api/shipments/show.json.jbuilder

@@ -23,7 +23,7 @@ json.cache! [I18n.locale, @shipment] do
       json.(shipping_category, :id, :name)
     end
   end
-  json.manifest(@shipment.manifest) do |manifest_item|
+  json.manifest(@shipment.shipping_manifest_items) do |manifest_item|
     json.variant do
       json.partial!("spree/api/variants/small", variant: manifest_item.variant)
     end

backend/app/views/spree/admin/orders/confirm/_shipment_manifest.html.erb

@@ -1,4 +1,4 @@
-<% shipment.manifest.each do |item| %>
+<% shipment.shipping_manifest_items.each do |item| %>
   <tr class="stock-item" data-item-quantity="<%= item.quantity %>">
     <td class="item-image">
       <%= render 'spree/admin/shared/image',

backend/spec/features/admin/orders/order_details_spec.rb

@@ -332,7 +332,7 @@
             visit spree.edit_admin_order_path(order)
 
             expect(order.shipments.count).to eq(1)
-            expect(order.shipments.first.manifest.count).to eq(2)
+            expect(order.shipments.first.shipping_manifest_items.count).to eq(2)
 
             within('tr', text: line_item.sku) { click_icon 'arrows-h' }
             complete_split_to(stock_location2)

core/app/mailers/spree/carton_mailer.rb

@@ -18,7 +18,7 @@ class CartonMailer < BaseMailer
     def shipped_email(options, _deprecated_options = {})
       @order = options.fetch(:order)
       @carton = options.fetch(:carton)
-      @manifest = @carton.manifest_for_order(@order)
+      @shipping_manifest_for_order = @carton.manifest_for_order(@order)
       options = { resend: false }.merge(options)
       @store = @order.store
       subject = (options[:resend] ? "[#{t('spree.resend').upcase}] " : '')

core/app/models/spree/carton.rb

@@ -45,15 +45,27 @@ def display_shipped_at
     shipped_at.to_s(:rfc822)
   end
 
-  def manifest
-    @manifest ||= Spree::ShippingManifest.new(inventory_units: inventory_units).items
+  def shipping_manifest_items
+    @shipping_manifest_items ||= shipping_manifest.items
   end
 
-  def manifest_for_order(order)
-    Spree::ShippingManifest.new(inventory_units: inventory_units).for_order(order).items
+  alias manifest shipping_manifest_items
+  deprecate manifest: :shipping_manifest_items, deprecator: Spree::Deprecation
+
+  def shipping_manifest_for_order(order)
+    shipping_manifest.for_order(order).items
   end
 
+  alias manifest_for_order shipping_manifest_for_order
+  deprecate manifest_for_order: :shipping_manifest_for_order, deprecator: Spree::Deprecation
+
   def any_exchanges?
     inventory_units.any?(&:original_return_item)
   end
+
+  private
+
+  def shipping_manifest
+    @shipping_manifest ||= Spree::ShippingManifest.new(inventory_units: inventory_units)
+  end
 end

core/app/models/spree/shipment.rb

@@ -106,11 +106,11 @@ def add_shipping_method(shipping_method, selected = false)
     deprecate :add_shipping_method, deprecator: Spree::Deprecation
 
     def after_cancel
-      manifest.each { |item| manifest_restock(item) }
+      shipping_manifest_items.each { |item| manifest_restock(item) }
     end
 
     def after_resume
-      manifest.each { |item| manifest_unstock(item) }
+      shipping_manifest_items.each { |item| manifest_unstock(item) }
     end
 
     def backordered?
@@ -230,10 +230,13 @@ def selected_shipping_rate
       shipping_rates.detect(&:selected?)
     end
 
-    def manifest
-      @manifest ||= Spree::ShippingManifest.new(inventory_units: inventory_units).items
+    def shipping_manifest_items
+      @shipping_manifest_items ||= shipping_manifest.items
     end
 
+    alias manifest shipping_manifest_items
+    deprecate manifest: :shipping_manifest_items, deprecator: Spree::Deprecation
+
     def selected_shipping_rate_id
       selected_shipping_rate.try(:id)
     end
@@ -395,6 +398,10 @@ def address
 
     private
 
+    def shipping_manifest
+      @shipping_manifest ||= Spree::ShippingManifest.new(inventory_units: inventory_units)
+    end
+
     def after_ship
       order.shipping.ship_shipment(self, suppress_mailer: suppress_mailer)
     end

core/app/views/spree/carton_mailer/shipped_email.html.erb

@@ -11,7 +11,7 @@
         <%= t('spree.shipment_mailer.shipped_email.shipment_summary') %>
       </p>
       <table>
-        <% @manifest.each do |item| %>
+        <% @shipping_manifest_for_order.each do |item| %>
           <tr>
             <td><%= item.variant.sku %></td>
             <td><%= item.variant.product.name %></td>

core/app/views/spree/carton_mailer/shipped_email.text.erb

@@ -5,7 +5,7 @@
 ============================================================
 <%= t('spree.shipment_mailer.shipped_email.shipment_summary') %>
 ============================================================
-<% @manifest.each do |item| %>
+<% @shipping_manifest_for_order.each do |item| %>
   <%= item.variant.sku %> <%= item.variant.product.name %> <%= item.variant.options_text %>
 <% end %>
 ============================================================

core/spec/models/spree/carton_spec.rb

@@ -83,7 +83,16 @@
   end
 
   describe "#manifest" do
-    subject { carton.manifest }
+    it "is deprecated" do
+      Spree::Deprecation.silence do
+        expect(Spree::Deprecation).to(receive(:warn))
+        Spree::Shipment.new.manifest
+      end
+    end
+  end
+
+  describe "#shipping_manifest_items" do
+    subject { carton.shipping_manifest_items }
 
     let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
     let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
@@ -97,6 +106,15 @@
   end
 
   describe "#manifest_for_order" do
+    it "is deprecated" do
+      Spree::Deprecation.silence do
+        expect(Spree::Deprecation).to(receive(:warn))
+        Spree::Carton.new.manifest_for_order(create(:order))
+      end
+    end
+  end
+
+  describe "#shipping_manifest_for_order" do
     subject { carton.manifest_for_order(first_order) }
 
     let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }

core/spec/models/spree/shipment_spec.rb

@@ -187,21 +187,30 @@
     expect(shipment.total).to eq(8)
   end
 
-  context "manifest" do
+  describe "#manifest_items" do
     let(:order) { create(:order) }
     let(:variant) { create(:variant) }
     let!(:line_item) { order.contents.add variant }
     let!(:shipment) { order.create_proposed_shipments.first }
 
     it "returns variant expected" do
-      expect(shipment.manifest.first.variant).to eq variant
+      expect(shipment.shipping_manifest_items.first.variant).to eq variant
     end
 
     context "variant was removed" do
       before { variant.discard }
 
       it "still returns variant expected" do
-        expect(shipment.manifest.first.variant).to eq variant
+        expect(shipment.shipping_manifest_items.first.variant).to eq variant
+      end
+    end
+  end
+
+  context "manifest" do
+    it "is deprecated" do
+      Spree::Deprecation.silence do
+        expect(Spree::Deprecation).to(receive(:warn))
+        Spree::Shipment.new.manifest
       end
     end
   end

frontend/app/views/spree/checkout/_delivery.html.erb

@@ -24,7 +24,7 @@
               <th><%= t('spree.price') %></th>
             </thead>
             <tbody>
-              <% ship_form.object.manifest.each do |item| %>
+              <% ship_form.object.shipping_manifest_items.each do |item| %>
                 <tr class="stock-item">
                   <td class="item-image">
                     <%= render 'spree/shared/image',