[SemaStmt] Replace check that was mistakenly removed for complicated …

…stride calculation in a cilk_for.
neboat · Jan 9, 2024 · 63b6302 · 63b6302
1 parent aee817f
commit 63b6302
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp
@@ -3589,6 +3589,8 @@ StmtResult Sema::HandleSimpleCilkForStmt(SourceLocation CilkForLoc,
     StrideIsNegative = StrideWithSign.second;
     Stride = StrideWithSign.first;
   }
+  if (!StrideIsUnit && !Stride)
+    return StmtEmpty();
 
   // Determine the type of comparison.
   //

diff --git a/clang/test/Cilk/cilkfor-complicated-stride.c b/clang/test/Cilk/cilkfor-complicated-stride.c
@@ -0,0 +1,11 @@
+// Check that Clang properly handles cilk_for loops with complicated stride
+// calculations.
+//
+// RUN: %clang_cc1 %s -fopencilk -verify -fsyntax-only
+// expected-no-diagnostics
+
+void test(char *data, unsigned long size)
+{
+  _Cilk_for (unsigned long i = 0; i < size; i = i + (1 << 21))
+    ((char*) data)[i] = 0;
+}