New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kudos repo to the i-am-human monorepo #79

Merged

amityadav0 merged 26 commits into master from kudos

Sep 13, 2023

Contributor

amityadav0 commented Aug 25, 2023

No description provided.


          move kudos to i-am-human monorepo

af80375

amityadav0 requested a review from a team as a code owner

August 25, 2023 09:12

amityadav0 requested review from robert-zaremba and sczembor

August 25, 2023 09:13

amityadav0 added 8 commits

August 30, 2023 12:02


          merge

e6fb2d7


          lint

f7bea5c


          lint

c0ae7e2


          lint

1cac228


          lint

61f1045


          lint

e27e246


          Merge branch 'master' into kudos

0817cea


          Merge branch 'master' into kudos

49b7d6b

robert-zaremba reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

contracts/kudos/.gitignore Outdated Show resolved Hide resolved

contracts/kudos/Cargo.toml Outdated Show resolved Hide resolved

contracts/kudos/Cargo.toml Outdated Show resolved Hide resolved

contracts/kudos/LICENSE Outdated Show resolved Hide resolved

contracts/kudos/README.md Outdated Show resolved Hide resolved

contracts/kudos/README.md Outdated Show resolved Hide resolved

contracts/kudos/README.md Outdated Show resolved Hide resolved

contracts/kudos/README.md Outdated Show resolved Hide resolved

contracts/kudos/src/callbacks/exchange_kudos_for_sbt.rs Show resolved Hide resolved

robert-zaremba and others added 8 commits

September 5, 2023 10:15


          Apply suggestions from code review


          Apply suggestions from code review

2cd2807

Co-authored-by: Robert Zaremba <[email protected]>


          update makefile

064cea3


          remove gitignore

3d43bcb


          Merge branch 'master' into kudos

f4c2ddd


          Merge branch 'master' into kudos

5e4aaf3


          Merge branch 'master' into kudos

64c12d7


          Merge branch 'master' into kudos

f9ee443

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

c16cf8f

Co-authored-by: sczembor <[email protected]>

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved


          Update contracts/kudos/README.md

d50f9cc

Co-authored-by: sczembor <[email protected]>

sczembor reviewed

View reviewed changes

contracts/kudos/src/callbacks/exchange_kudos_for_sbt.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/src/callbacks/exchange_kudos_for_sbt.rs Show resolved Hide resolved

sczembor reviewed

View reviewed changes

Contributor

sczembor left a comment

lets add doc comments to all the methods, explaining what they do and what are the edge cases /// Does this and that, panics if...

amityadav0 and others added 2 commits

September 11, 2023 19:25


          Apply suggestions from code review

a9f5e59

Co-authored-by: sczembor <[email protected]>


          add doc comments, update

9ca7673

sczembor reviewed

View reviewed changes

contracts/kudos/src/callbacks/exchange_kudos_for_sbt.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/src/callbacks/exchange_kudos_for_sbt.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

Contributor

sczembor left a comment •

edited

Loading

wrong notation. Here is the example on how it should be commented.

/// It explains what the function does.
fn my_function() {
    // Function implementation
}

amityadav0 added 2 commits

September 13, 2023 06:57


          minor update

0d2785e


          lint:

5e79251

Contributor Author

amityadav0 commented Sep 13, 2023

Updated

amityadav0 requested a review from sczembor

September 13, 2023 01:31

sczembor reviewed

View reviewed changes

contracts/kudos/src/callbacks/leave_comment.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/tests/workspaces.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/tests/workspaces.rs Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

contracts/kudos/README.md Outdated Show resolved Hide resolved

amityadav0 and others added 3 commits

September 13, 2023 18:46


          minor update

f1ead14


          Apply suggestions from code review

f8cd303

Co-authored-by: sczembor <[email protected]>


          Merge branch 'master' into kudos

0fd79d4

sczembor approved these changes

View reviewed changes

Contributor

sczembor left a comment

lgtm

amityadav0 enabled auto-merge (squash)

September 13, 2023 13:23

amityadav0 merged commit d4be5f7 into master

3 checks passed

amityadav0 deleted the kudos branch

September 13, 2023 13:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet