New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc easy polls #65

Merged

sczembor merged 50 commits into master from poc_easy_polls

Sep 13, 2023

Contributor

sczembor commented Aug 8, 2023

No description provided.

sczembor and others added 10 commits

July 20, 2023 19:34


          draft

dea3c21


          draft

e8f1d3f


          draft

a7b66d6


          finish respond method; add simple unit test

afe26d2


          add custom errors

d4a35d8


          add unit tests for responds

f74f123


          improve the respond implementation

bffd781


          add corss contract call to registry

7929cf1


          implement text_answers result method

73b55b1


          Merge branch 'master' into poc_easy_polls

a2265da

sczembor requested a review from robert-zaremba

August 10, 2023 17:53

robert-zaremba reviewed

View reviewed changes

Contributor

robert-zaremba left a comment

quick review of the structs

contracts/easy-poll/Cargo.toml Outdated Show resolved Hide resolved

contracts/easy-poll/Cargo.toml Outdated Show resolved Hide resolved

contracts/easy-poll/README.md Outdated Show resolved Hide resolved

contracts/easy-poll/src/constants.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/constants.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Outdated Show resolved Hide resolved

sczembor and others added 6 commits

August 11, 2023 15:21


          update the structure

ecd2a83


          Merge branch 'poc_easy_polls' of https://github.com/near-ndc/i-am-human…

8863cae

… into poc_easy_polls


          merge

e768996


          Merge branch 'master' into poc_easy_polls

6e9a85a


          Update contracts/easy-poll/Cargo.toml

da4476b

Co-authored-by: Robert Zaremba <[email protected]>


          Apply suggestions from code review

197e3bf

Co-authored-by: Robert Zaremba <[email protected]>

amityadav0 reviewed

View reviewed changes

contracts/easy-poll/src/ext.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor added 2 commits

August 11, 2023 16:49


          update the structs, apply code review suggestions; improve the unit t…

bd867f8

…ests


          apply code review suggestions

35af0ea

sczembor marked this pull request as ready for review

August 11, 2023 17:05

sczembor requested a review from a team as a code owner

August 11, 2023 17:05


          add more unit tests; remove unused structs

791eca9

sczembor requested review from robert-zaremba and amityadav0

August 14, 2023 12:17

amityadav0 reviewed

View reviewed changes

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor and others added 2 commits

August 30, 2023 12:50


          Merge branch 'master' into poc_easy_polls

e601730


          apply code review suggestions

eebbe4a

amityadav0 reviewed

View reviewed changes

Contributor

amityadav0 left a comment

Added few comments

contracts/easy-poll/src/ext.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Show resolved Hide resolved

contracts/easy-poll/src/storage.rs Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor and others added 2 commits

August 31, 2023 15:55


          add comment'

f8b137a


          Merge branch 'master' into poc_easy_polls

54b8ab2

robert-zaremba reviewed

View reviewed changes

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Show resolved Hide resolved

sczembor and others added 4 commits

September 8, 2023 15:54


          Update contracts/easy-poll/src/lib.rs

3f2ac05

Co-authored-by: Robert Zaremba <[email protected]>


          Update contracts/easy-poll/src/lib.rs

b2d3045

Co-authored-by: Robert Zaremba <[email protected]>


          add events

12c5af8


          apply code review suggestions

590c4f1

sczembor requested a review from robert-zaremba

September 11, 2023 13:39


          add serialize, deserialize

sczembor requested a review from amityadav0

September 11, 2023 13:55

robert-zaremba reviewed

View reviewed changes

contracts/easy-poll/src/events.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/events.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/events.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor and others added 3 commits

September 11, 2023 17:43


          Apply suggestions from code review

d5dd012

Co-authored-by: Robert Zaremba <[email protected]>


          apply code review suggestions

56519f9


          test fix

b9b4a56

robert-zaremba reviewed

View reviewed changes

contracts/easy-poll/src/errors.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/errors.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/errors.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/errors.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor and others added 6 commits

September 12, 2023 15:30


          Apply suggestions from code review

ab96d0b

Co-authored-by: Robert Zaremba <[email protected]>

fix

ab8cc91


          Update contracts/easy-poll/src/lib.rs

249fedd

Co-authored-by: Robert Zaremba <[email protected]>


          move debug to test only

397752a


          Merge branch 'poc_easy_polls' of https://github.com/near-ndc/i-am-human…

e54afa4

… into poc_easy_polls


          refactor on_human_verifed and initalize_results methods

3a4c741

robert-zaremba requested changes

View reviewed changes

Contributor

robert-zaremba left a comment

We must not return whole Vector from the store. With many answers, it will kill the contract!

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

sczembor added 2 commits

September 13, 2023 12:31


          do not store answers on chain

f5a3510


          apply code review suggestions

ef83ec9

robert-zaremba approved these changes

View reviewed changes

Contributor

robert-zaremba left a comment

lgtm

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

contracts/easy-poll/src/lib.rs Outdated Show resolved Hide resolved

robert-zaremba and others added 3 commits

September 13, 2023 13:30


          Update contracts/easy-poll/src/lib.rs

dd10a8e


          Update contracts/easy-poll/src/lib.rs

046db48

Co-authored-by: Robert Zaremba <[email protected]>


          change choices to unique vector rather than true/false

747d479

sczembor merged commit d58c8ae into master

3 checks passed

sczembor deleted the poc_easy_polls branch

September 13, 2023 12:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet