Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore runtime config in hsts check #166

Merged
merged 1 commit into from
May 19, 2024
Merged

ignore runtime config in hsts check #166

merged 1 commit into from
May 19, 2024

Conversation

btmo
Copy link
Contributor

@btmo btmo commented May 13, 2024

I was going through https://hexdocs.pm/phoenix/using_ssl.html to set up SSL for a Phoenix service.
According to the documentation:

It is important to note that force_ssl: is a compile time config, so it normally is set in prod.exs, it will not work when set from runtime.exs.

Sobelow currently warns when runtime.exs contains https settings but no force_ssl.
This PR suggests to ignore the runtime.exs file when checking HSTS.

@houllette
Copy link
Contributor

Change makes total sense to me - thanks for the thorough PR!

@houllette houllette merged commit b47ad2f into nccgroup:master May 19, 2024
10 checks passed
@btmo btmo deleted the fix/hsts-runtime-check branch May 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants