-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: ontology_submission.rb file to isolate the processing steps #143
Refactor: ontology_submission.rb file to isolate the processing steps #143
Conversation
747b902
to
b09fd4e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 80.07% 78.21% -1.87%
==========================================
Files 65 72 +7
Lines 5003 5131 +128
==========================================
+ Hits 4006 4013 +7
- Misses 997 1118 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manually merged this PR to https://github.com/ncbo/ontologies_linked_data/tree/develop |
this PR overwrite metrics calculation changes introduced in #182. Those changes need to be re-applied. |
Yes, this PR is too old, it needs to be updated. |
manually merged |
OK great, keep me informed, If support is needed on this. |
Why
The current model ontologies_submission.rb (which represents the submission concept) contains more than 1500 lines, including in the same time the model information (its attributes e.g submissionId) and the model operations ( e.g parsing, diff, ...).
This PL isolates the different operations into separate modules. Making the ontologies_submission.rb file smaller (600 lines), easier to read and maintain