Add support for GitHub and ORCID identifiers, plus enhancements to user account management #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper methods for text associated with custom ontology sets.
This is now handled by a separate passwords controller
No longer using a common form for new and edit
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| p = params.require(:user).permit(:firstName, :lastName, :username, :email, :email_confirmation, :password, | ||
| :password_confirmation, :register_mail_list, :admin) | ||
| p = params.require(:user).permit(:firstName, :lastName, :username, :email, :password, :password_confirmation, | ||
| :admin, :githubId, :orcidId) |
Check failure
Code scanning / Brakeman
Potentially dangerous key allowed for mass assignment. Error
There was a problem hiding this comment.
The :admin key was already present in the previous revision of this code. It's associated with the "Grant admin privileges" checkbox, and is only visible on the edit account page if the logged-in user is an administrator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces optional functionality for users to associate their GitHub usernames and ORCID iDs with their BioPortal accounts. Additionally, it includes several incremental improvements and refactoring efforts for the account and login pages to enhance the overall user experience.
Account creation page enhancements
Account show and edit page improvements
Password management
UsersControllerValidation and code cleanup
form_forwithform_withUsersHelperto improve view layer code cleanlinessaccount.scssto house CSS code for account pageslogin/indexandlogin/lost_passwordfrom ERB to HAML