Backend,Frontend,Tests: rm txDetail from SignedTx #271
+1,002
−1,308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETC was previously marked as non-centeralized[1], this commit removes this flag since it's no longer needed. [1] 9392215
This commit updates Nethereum to latest version to support extracting token transfer amount from the raw tx created when sending (hot-storage) or signing (cold-storage). It's noteworthy to say that Web3 no longer accepts a timeout as an argument. Nethereum now supports different types of transactions like those that support EIP-1559, at this moment there's no clear benefit for migrating especially given the fact that it will causes incompatiblity with ETC so we will continue to use Legacy types for now.
This commit removes the redundant proposal and metadata from the SignedTransaction type.
webwarrior-ws
commented
Apr 11, 2024
| @@ -76,16 +76,16 @@ type Serialization() = | |||
|
|
|||
| [<Test>] | |||
| member __.``signed SAI transaction export``() = | |||
| DestinationAddress = destinationAddress | ||
| } | ||
| txDetails :> ITransactionDetails | ||
| let GetSignedTransactionProposal (signedTx: SignedTransaction): UnsignedTransactionProposal = |
There was a problem hiding this comment.
missing new line before function definition
| { | ||
| TransactionMetadata.Fee = | ||
| MinerFee(minerFee.Satoshi, DateTime.Now, signedTx.FeeCurrency) | ||
| // We don't need inputs since the metadata object gets casted to IBlockchainFeeInfo |
There was a problem hiding this comment.
In that case, why create TransactionMetadata instance at all?
Use new ElectrumSharp exceptions; set logger.
Add some library references to XF.Android project. Also remove unused references.
To avoid version conflicts on windows--legacyFramework-only CI lane.
To avoid version conflicts on windows--legacyFramework-only CI lane.
Trying to fix the following error: ``` System.Exception: Some problem when connecting to electrum.blockstream.info ---> System.IO.FileLoadException: Could not load file or assembly 'Microsoft.VisualStudio.Threading, Version=17.6.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040) ```
knocte
force-pushed
the
master
branch
2 times, most recently
from
b841302 to
ccb1641
Compare
|
Superseded by #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #238
Superseded by #298