Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend.XF.*: fix references in .fsproj files #235

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Frontend.XF.*: fix references in .fsproj files #235

merged 1 commit into from
Feb 5, 2024

Conversation

webwarrior-ws
Copy link
Contributor

Fix project references in Fronend.XF.*.fsproj files by adding <Project> element with project guid to each project reference. This is needed to avoid "error : Unrecognized Guid format" error when loading projects in Visual Studio 2022.

@knocte
Copy link
Member

knocte commented Oct 18, 2023

@webwarrior-ws wrong scope in commit msg title; you wrote Frontend.XF, but you're not changing that project or any file inside the Frontend.XF folder. I guess you meant Frontend.XF.*.

Fix project references in Fronend.XF.*.fsproj files by adding
<Project> element with project guid to each project reference.
This is needed to avoid "error : Unrecognized Guid format"
error when loading projects in Visual Studio 2022.
@webwarrior-ws webwarrior-ws changed the title Frontend.XF: fix references in .fsproj files Frontend.XF.*: fix references in .fsproj files Oct 23, 2023
@webwarrior-ws
Copy link
Contributor Author

@webwarrior-ws wrong scope in commit msg title; you wrote Frontend.XF, but you're not changing that project or any file inside the Frontend.XF folder. I guess you meant Frontend.XF.*.

Fixed commit and PR title.

@knocte
Copy link
Member

knocte commented Feb 2, 2024

This is needed to avoid "error : Unrecognized Guid format" error when loading projects in Visual Studio 2022.

Do you still get this error if this PR is not merged?

@webwarrior-ws
Copy link
Contributor Author

This is needed to avoid "error : Unrecognized Guid format" error when loading projects in Visual Studio 2022.

Do you still get this error if this PR is not merged?

Yes

@knocte
Copy link
Member

knocte commented Feb 5, 2024

How about the stable branch?

@webwarrior-ws
Copy link
Contributor Author

How about the stable branch?

stable doens't have Frontend.XF.* projects

@knocte
Copy link
Member

knocte commented Feb 5, 2024

So VS builds fine in stable?

@webwarrior-ws
Copy link
Contributor Author

So VS builds fine in stable?

Yes

@knocte knocte merged commit 46d5ef7 into nblockchain:master Feb 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants