Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base Image to Elixir 1.18.1 and Erlang 27.2 #688

Merged
merged 3 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
erlang 27.1.2
elixir 1.17.3
erlang 27.2
elixir 1.18.1
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
########################################################################

# renovate: datasource=github-tags depName=elixir packageName=elixir-lang/elixir versioning=semver
ARG ELIXIR_VERSION=1.17.3
ARG ELIXIR_VERSION=1.18.1
# renovate: datasource=github-tags depName=erlang packageName=erlang/otp versioning=regex:^(?<major>\d+?)\.(?<minor>\d+?)(\.(?<patch>\d+))?$ extractVersion=^OTP-(?<version>\S+)
ARG OTP_VERSION=27.1.2
ARG OTP_VERSION=27.2
# renovate: datasource=docker depName=ubuntu packageName=ubuntu versioning=ubuntu
ARG UBUNTU_VERSION=jammy-20240808

Expand Down
2 changes: 1 addition & 1 deletion lib/backpex/fields/has_many.ex
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ defmodule Backpex.Fields.HasMany do
end

defp validate_live_resource(field_name, field_options) do
unless Map.has_key?(field_options, :live_resource) do
if !Map.has_key?(field_options, :live_resource) do
raise "The field #{field_name} does not have the required key :live_resource defined."
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/backpex/fields/has_many_through.ex
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ defmodule Backpex.Fields.HasManyThrough do
max_width="xl"
>
<div class="py-3">
<div :for={e <- @editables} class={[unless(e.index == @edit_relational, do: "hidden")]}>
<div :for={e <- @editables} class={[if(e.index != @edit_relational, do: "hidden")]}>
{hidden_inputs_for(e)}
<.select_relational_field
form={e}
Expand Down
7 changes: 2 additions & 5 deletions lib/backpex/html/layout.ex
Original file line number Diff line number Diff line change
Expand Up @@ -515,18 +515,15 @@ defmodule Backpex.HTML.Layout do
<div id="modal">
<div
id="modal-overlay"
class={[
"animate-fade-in bg-neutral fixed inset-0 z-50 bg-opacity-40 transition-opacity",
unless(@open, do: "hidden")
]}
class={["animate-fade-in bg-neutral fixed inset-0 z-50 bg-opacity-40 transition-opacity", if(!@open, do: "hidden")]}
aria-hidden="true"
>
</div>
<div
id="modal-content"
class={[
"fixed inset-0 z-50 my-4 flex transform items-center justify-center overflow-hidden px-4 sm:px-6",
unless(@open, do: "hidden")
if(!@open, do: "hidden")
]}
role="dialog"
aria-modal="true"
Expand Down
Loading