Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactify number #1174

Merged
merged 9 commits into from
May 31, 2024
Merged

Reactify number #1174

merged 9 commits into from
May 31, 2024

Conversation

lotorvik
Copy link
Contributor

  • Use Aksel TextField
  • Allow all input, but validate input
  • Validate integer(numberic) and decimal
  • Use comma in decimals in min/max error messages
  • Allow extra spaces and dot, but strip when saving

@lotorvik lotorvik requested a review from a team as a code owner May 28, 2024 14:11
enstulen
enstulen approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@enstulen enstulen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔢 🌮

packages/shared-components/src/formio/components/core/textfield/TextField.tsx Outdated
@@ -33,13 +31,17 @@ class TextField extends BaseComponent {
return 'text';
}

handleChange(value: string): any {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sjekk any

packages/shared-domain/src/utils/numberUtils.ts Outdated Show resolved Hide resolved
@lotorvik lotorvik merged commit cf934dc into master May 31, 2024
10 checks passed
@lotorvik lotorvik deleted the feature/reactify-number branch May 31, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enstulen enstulen enstulen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lotorvik @enstulen