Gå over fra Create-react-app til Vite #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusae
commented
Jan 3, 2025
| import {DateTimePicker, LocalizationProvider} from '@mui/x-date-pickers'; | ||
| import {AdapterDayjs} from '@mui/x-date-pickers/AdapterDayjs'; | ||
| import React, { useState } from 'react'; | ||
| import { TextField, Button, Box, Alert, Table, TableBody, TableCell, TableContainer, TableHead, TableRow, Paper } from '@mui/material'; |
There was a problem hiding this comment.
Jeg begynte på å bytte ut disse med Akselkomponenter, men snudde da jeg ikke helt fant ut av datepickeren. Sparer det derfor til en senere anledning.
b162214
approved these changes
Jan 6, 2025
| @@ -13,20 +13,24 @@ jobs: | |||
| name: Build, push and deploy | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| REACT_APP_BASE_URL: ${{ secrets.REACT_APP_BASE_URL }} | |||
| VITE_REACT_APP_BASE_URL: ${{ secrets.REACT_APP_BASE_URL }} | |||
There was a problem hiding this comment.
Hva er grunnen til at base url er i en github secret?
There was a problem hiding this comment.
Tipper @mettok er rett mann å spørre om dette. Jeg tenker at vi evt. kan gjøre litt om på det når han kommer tilbake fra ferie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi ønsker å bruke Vite istedenfor create-react-app.
Bonus: Bytt ut en del av Material-UI-komponentene med komponenter fra Aksel.