Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] Updated Focus design for Checkbox, Radio and Switch #3513

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 21, 2025

Description

We are experimenting with a new way to show focus-markings on a few components after some inspiration from designsystemet.no

Screenshot 2025-01-21 at 08 43 48 Screenshot 2025-01-21 at 08 43 37

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh self-assigned this Jan 21, 2025
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: e147e5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Storybook demo / Chromatic

d2287ab5c | 91 components | 135 stories

it-vegard
it-vegard previously approved these changes Jan 22, 2025
@HalvorHaugan
Copy link
Contributor

Var det meningen å øke mellomrommet mellom checkbox og label i gammel checkbox?

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Jan 22, 2025

Var det meningen å øke mellomrommet mellom checkbox og label i gammel checkbox?

Nice catch, fixed now by hiding the new dom-node in old CSS.

@KenAJoh KenAJoh enabled auto-merge (squash) January 22, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants