[Darkside] Quality assurance P1 #3510
Conversation
|
| outline: 2px solid var(--ax-border-focus); | ||
| outline-offset: 2px; |
There was a problem hiding this comment.
This is part of a new test for focus-markings. I will create a separate PR for all the other components updating this.
| @@ -230,7 +238,7 @@ | |||
| /* dropdown & non selectable dropdown items */ | |||
|
|
|||
| .navds-combobox__list { | |||
| max-height: 290px; | |||
There was a problem hiding this comment.
This size is a little arbitrary, but helps a little with this issue: #3498. By adjusting the height, you will by default see part of the last item before scrolling.
There was a problem hiding this comment.
We are testing using a little darker "default"-scale for strong. This makes primary-neutral buttons, ToggleGroup, Tag etc more defined and visually equal to the counterparts with "role"
Storybook demo / Chromatic📝 Changes to review: 23b1b835ab | 91 components | 135 stories |
Description
We are now in the process of testing each component and verifying the sync between Figma and code
This PR is one of many to more with small adjustments and fixes made to the darkside system. The changes made here was from reviewing Accordion -> ErrorSummary. There are some changes not included here that was found, but will create separate PRs for those because of the scale. So this PR can be merged as is.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")