[Actions] ⚡ Optimize workflows #3480
Conversation
|
There was a problem hiding this comment.
This solved a AXE-test issue where it said the icon without aria-labelledby did not have a label
scripts/eslint/import-check.js
Outdated
There was a problem hiding this comment.
By validating imports before commit, we can get instant feedback and be more sure of sandbox working. We also avoid having to check all the examples in sandbox with e2e
There was a problem hiding this comment.
We can remove this and save a bunch of time since we can validate stories before build
- Validate URL-length: aksel.nav.no/website/scripts/update-examples/parts/parse-code-files.ts
- Validate imports with ESLINT
If both if these make no changes/has no errors, we can assue that the demo works. Just in case i added a new sandbox.e2e.ts test that checks that the sandbox itself is working with ds-react
There was a problem hiding this comment.
Since the dialog is already in the dom, a reagular AXE-scan in "verify-all" already checks for a11y in the search.
Storybook demo / Chromatic9990e4aeb | 91 components | 135 stories |
Description
https://github.com/navikt/aksel/actions/metrics/performance
Optimized some of our actions and removed duplicate code by creating some "composite" actions. We now only have to update a single action when changing build and boot.
Lessons:
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")