You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we use lightningCSS to transpile anyways, I think we should use the modern syntax as it's much easier to reason about imo. (less 🧠 required, I always mix up what min-width means in the media query == does that apply when above the threshold or below it?)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Nice 💅 While a nice improvement, i think it would make sense to set this PR "on hold" until we have the other darkside PRs merged. Merging this now would lead to quite a few merge-conflicts, so easier to implement after the fact 🤞
Couldn't find a good stylelint rule for it (maybe the attribute blacklist), but it would be nice to prefer the shorthand background to background-color too 🤔 (this rule's not that big of a deal).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal tooling PR
Since we use lightningCSS to transpile anyways, I think we should use the modern syntax as it's much easier to reason about imo. (less 🧠 required, I always mix up what
min-widthmeans in the media query == does that apply when above the threshold or below it?)