Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/combobox grouped options #3317

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

it-vegard
Copy link
Contributor

@it-vegard it-vegard commented Nov 1, 2024

Description

Group options with a heading for when several types of content is used within one Combobox.

Fixes #2706

Work in progress. Probably needs to do something for darkmode or add new tokens? Need to document and create example for Aksel-website.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: ed232a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Storybook demo / Chromatic

📝 Endringer til review: 1

b20b14984 | 91 komponenter | 144 stories

@KenAJoh KenAJoh added On hold ⏸️ PR is on hold, no need for review yet! and removed jobbes med 💨 labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forespørsel 🥰 Ønsker fra folk komponenter 🧩 On hold ⏸️ PR is on hold, no need for review yet!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: Combobox - gruppering av options
2 participants