[WIP] Add optional MurmurHash support #142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
murmur-hash-alg
branch
from
3dab9c0 to
0072fe8
Compare
kusalk
force-pushed
the
murmur-hash-alg
branch
from
0072fe8 to
9989505
Compare
kusalk
force-pushed
the
murmur-hash-alg
branch
from
9989505 to
2523f2d
Compare
kusalk
force-pushed
the
murmur-hash-alg
branch
from
2523f2d to
1a11e95
Compare
kusalk
force-pushed
the
murmur-hash-alg
branch
from
1a11e95 to
a5747d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Await merge of #134 first
The changes encompassed in this PR were originally included with those in #134. I extracted these change into this separate PR following a discussion in the former PR.
This PR introduces support for MurmurHash as an alternative to the default MD5. In my experience it is over 4x faster at hashing (rough benchmarks below).
MurmurHash can be activated with the following argument
-Dhash.algorithm=murmur. The argument must be supplied to both the agent and collector.Benchmark:
MethodRegistry#getHashScenario:
ConcurrentHashMapcache disabled