Bump up spring boot 3 #124
Conversation
Scavenger Test Results161 files 161 suites 1m 28s ⏱️ Results for commit 8e9bc8e. ♻️ This comment has been updated with latest results. |
scavenger-collector/src/main/kotlin/com/navercorp/scavenger/config/JdbcConfig.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Replace io.github.microutils:kotlin-logging-jvm with https://github.com/oshai/kotlin-logging
| fun toInstantMicro(instant: Instant): Instant { | ||
| val epochMicro = (instant.epochSecond * 1_000_000) + (instant.nano / 1000) | ||
| return Instant.ofEpochSecond(epochMicro / 1_000_000, (epochMicro % 1_000_000) * 1000) | ||
| } |
There was a problem hiding this comment.
After switching to jdk17, when using Instant.now(), I modified it to use micro because it tends to use different time precision depending on the OS.
That's why the test was previously crashed.
MySQL permits fractional seconds for TIME, DATETIME, and TIMESTAMP values, with up to microseconds (6 digits) precision.
https://dev.mysql.com/doc/refman/8.4/en/date-and-time-type-syntax.html
There was a problem hiding this comment.
that's new to me, thanks 😄
| @@ -50,12 +50,11 @@ dependencies { | |||
| configure<DependencyManagementExtension> { | |||
| imports { | |||
| mavenBom(org.springframework.boot.gradle.plugin.SpringBootPlugin.BOM_COORDINATES) | |||
There was a problem hiding this comment.
Maybe this is also a configuration we need??
There was a problem hiding this comment.
I think yes.
It allows us to leverage the Spring Boot BOM to simplify dependency management, ensure version consistency, and reduce the risk of version conflicts in our Spring Boot project.
The SpringBootPlugin class provides a BOM_COORDINATES constant that can be used to import the bom without having to know its group ID, artifact ID, or version.
https://docs.spring.io/spring-boot/docs/3.2.4/gradle-plugin/reference/htmlsingle/#managing-dependencies.dependency-management-plugin.using-in-isolation
* Bump up grpc version - armeria : 1.26.0 -> 1.28.4 - grpcVersion : 1.58.0 -> 1.63.0 - grpcKotlinVersion : 1.2.1 -> 1.4.1 - grpcmock-junit5 : 0.9.4 -> 0.13.0 - add grpc-inprocess * Bump up protobuf version - protobuf : 3.20.1 -> 3.25.3 - not used coroutinesVersion gradle variable remove. Reviewed-by: @sohyun-ku @taeyeon-Kim
sohyun-ku
force-pushed
the
feature/bump-up-spring-boot-3
branch
from
4078520 to
8e9bc8e
Compare
related to #122
mysql:mysql-connector-java->com.mysql:mysql-connector-jjavax.servlet→jakarta.servletEntityConvertibleSqlParameterSourceFactorysignatureverifyZeroInteractions→verifyNoInteractionsDeprecatedverifyZeroInteractionsverifyZeroInteractions@ConstructorBinding