Skip to content

Commit

Permalink
Merge pull request #140 from naver/feature/Update-get-method-paramete…
Browse files Browse the repository at this point in the history
…rs-ways

Replace MethodNode.parameters usage with Type.getArgumentTypes

Reviewed-by: @taeyeon-Kim @kojandy
  • Loading branch information
sohyun-ku authored Dec 16, 2024
2 parents a932542 + 9f9f243 commit 1e9c0a4
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private Method(ClassNode classNode, MethodNode methodNode, boolean legacyCompati
private boolean isGetter(MethodNode methodNode) {
Type returnType = Type.getReturnType(methodNode.desc);

return (methodNode.parameters == null || methodNode.parameters.isEmpty())
return Type.getArgumentTypes(methodNode.desc).length == 0
&& returnType != Type.VOID_TYPE && (methodNode.name.startsWith("get")
|| (methodNode.name.startsWith("is") && returnType == Type.BOOLEAN_TYPE)
|| (methodNode.name.matches("component\\d+")) // kotlin component
Expand All @@ -75,8 +75,7 @@ private boolean isGetter(MethodNode methodNode) {

private boolean isSetter(MethodNode methodNode) {
return methodNode.name.startsWith("set")
&& methodNode.parameters != null
&& methodNode.parameters.size() == 1
&& Type.getArgumentTypes(methodNode.desc).length == 1
&& Type.getReturnType(methodNode.desc) == Type.VOID_TYPE;
}

Expand Down

0 comments on commit 1e9c0a4

Please sign in to comment.