Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share we add link option for custom highlight? #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YuCao16
Copy link

@YuCao16 YuCao16 commented Jul 18, 2023

This PR introduces the ability to link one highlight group to another within the plugin. This feature allows users to easily set up and manage complex highlight configurations.

@navarasu
Copy link
Owner

navarasu commented Aug 7, 2023

@YuCao16 Can you add an example to the doc?

@YuCao16
Copy link
Author

YuCao16 commented Aug 7, 2023

@YuCao16 Can you add an example to the doc?

Sure, I will, later today.

@YuCao16
Copy link
Author

YuCao16 commented Aug 7, 2023

@navarasu I have added one example in section Customization. By the way, I'd recommend we link NeoTreeWinSeparator to VertSplit:

NeoTreeWinSeparator = { link = "VertSplit" }

@echasnovski
Copy link
Contributor

This feature merged will make life of contributors and users a lot easier. For at least the following reasons:

  • Linking allows specifying only the highlight group name without the need to search in which table the similar highlight group is previously defined.
  • Linked highlight group can be safely defined before the group it is linked to.
  • Linked highlight groups means that they should be highlighted similarly. This allows users to tweak only one (original) highlight group and the others will also change how they are displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants