-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gold image processing action implementation #73
Merged
josecelano
merged 19 commits into
main
from
issue-71-create-base-image-generation-action
Jan 18, 2022
Merged
Gold image processing action implementation #73
josecelano
merged 19 commits into
main
from
issue-71-create-base-image-generation-action
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ ACTION | actionlint | 11 | 0 | 0.23s | |
✅ BASH | bash-exec | 4 | 0 | 0.02s | |
✅ BASH | shellcheck | 4 | 0 | 0.03s | |
✅ BASH | shfmt | 4 | 0 | 0.02s | |
✅ COPYPASTE | jscpd | yes | no | 2.19s | |
✅ CREDENTIALS | secretlint | yes | no | 2.56s | |
✅ DOCKERFILE | dockerfilelint | 1 | 0 | 0.22s | |
✅ DOCKERFILE | hadolint | 1 | 0 | 0.05s | |
✅ GIT | git_diff | yes | no | 0.06s | |
✅ JSON | eslint-plugin-jsonc | 8 | 0 | 0.91s | |
✅ JSON | jsonlint | 8 | 0 | 1.78s | |
✅ JSON | prettier | 8 | 0 | 1.1s | |
✅ JSON | v8r | 8 | 0 | 4.7s | |
✅ MARKDOWN | markdownlint | 13 | 0 | 0.36s | |
✅ MARKDOWN | markdown-link-check | 13 | 0 | 13.44s | |
✅ MARKDOWN | markdown-table-formatter | 13 | 0 | 0.25s | |
✅ PYTHON | bandit | 89 | 0 | 1.05s | |
✅ PYTHON | black | 89 | 0 | 1.63s | |
✅ PYTHON | flake8 | 89 | 0 | 1.13s | |
isort | 89 | 2 | 0.25s | ||
✅ PYTHON | mypy | 89 | 0 | 46.37s | |
✅ PYTHON | pylint | 89 | 0 | 12.41s | |
✅ SPELL | cspell | 137 | 0 | 6.27s | |
✅ SPELL | misspell | 137 | 0 | 0.1s | |
✅ YAML | prettier | 16 | 0 | 1.61s | |
✅ YAML | v8r | 16 | 0 | 10.67s | |
✅ YAML | yamllint | 16 | 0 | 0.31s |
See errors details in artifact MegaLinter reports on GitHub Action page
josecelano
approved these changes
Jan 10, 2022
src/nautilus_librarian/typer/commands/workflows/actions/generate_base_images_action.py
Outdated
Show resolved
Hide resolved
josecelano
approved these changes
Jan 13, 2022
josecelano
approved these changes
Jan 13, 2022
josecelano
approved these changes
Jan 13, 2022
josecelano
requested changes
Jan 14, 2022
src/nautilus_librarian/typer/commands/workflows/actions/rename_base_images_action.py
Outdated
Show resolved
Hide resolved
src/nautilus_librarian/typer/commands/workflows/gold_images_processing.py
Outdated
Show resolved
Hide resolved
yeraydavidrodriguez
changed the title
First gold image processing action implementation
Gold image processing action implementation
Jan 14, 2022
josecelano
approved these changes
Jan 14, 2022
josecelano
requested changes
Jan 17, 2022
src/nautilus_librarian/typer/commands/workflows/gold_images_processing.py
Outdated
Show resolved
Hide resolved
src/nautilus_librarian/typer/commands/workflows/actions/rename_base_images_action.py
Outdated
Show resolved
Hide resolved
src/nautilus_librarian/typer/commands/workflows/actions/rename_base_images_action.py
Outdated
Show resolved
Hide resolved
josecelano
approved these changes
Jan 18, 2022
src/nautilus_librarian/typer/commands/workflows/gold_images_processing.py
Outdated
Show resolved
Hide resolved
2 tasks
yeraydavidrodriguez
deleted the
issue-71-create-base-image-generation-action
branch
January 31, 2022 09:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements Issue 71: Image processing action.
This action will: