Add test case for expected_last_subject_sequence
#1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Aug 2, 2023
n1ghtmare
force-pushed
the
last-subject-sequence
branch
from
1cadfa1
to
5089e32
Compare
caspervonb
force-pushed
the
last-subject-sequence
branch
from
5089e32
to
0a6604d
Compare
Jarema
force-pushed
the
last-subject-sequence
branch
from
0a6604d
to
a66a540
Compare
|
@n1ghtmare this behaves correctly. The sequence provided is the last stream sequence for a given subject, not the count of messages in that subject. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might have found a bug,
expected_last_subject_sequenceappears to be wrong.