Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OL and UL to QuoteBlock #1771

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add OL and UL to QuoteBlock #1771

merged 5 commits into from
Jan 7, 2025

Conversation

jamesbiggs
Copy link
Collaborator

About these changes

Adds the option for OL and UL in the QuoteBlock's quote field.

Stops ReviewBlock inheriting QuoteBlock (they became too different)

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs merged commit 018194c into develop Jan 7, 2025
7 checks passed
@jamesbiggs jamesbiggs deleted the feature/quote-block-ul-ol branch January 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant