Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FCL-409] Upgrade Utilities and API Client #1519

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[FCL-409] Upgrade Utilities and API Client #1519

merged 2 commits into from
Oct 29, 2024

Conversation

jacksonj04
Copy link
Collaborator

@jacksonj04 jacksonj04 commented Oct 10, 2024 •
edited
Loading

  • Use the new stronger court data types in Utilities to improve integrity
  • Swap to using the new/improved Document.body behaviours in API Client
  • Swap factories to use the ones provided by API Client

Jira

FCL-409

@jacksonj04 jacksonj04 changed the title Bump versions of utils and api-client [FCL-409] Upgrade Utilities and API Client Oct 29, 2024
@jacksonj04 jacksonj04 marked this pull request as ready for review October 29, 2024 17:06
jacksonj04
jacksonj04 commented Oct 29, 2024
View reviewed changes
judgments/tests/factories.py Outdated
)
return judgment_mock()
def build(cls, **kwargs):
raise RuntimeError("Use caselawclient instead")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this for now, we can burn it entirely in future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burnt.

@jacksonj04 jacksonj04 enabled auto-merge October 29, 2024 17:12
@jacksonj04 jacksonj04 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 00d6cbe Oct 29, 2024
12 checks passed
@jacksonj04 jacksonj04 deleted the chore/apic-v27 branch October 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragon-dxw dragon-dxw dragon-dxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksonj04 @dragon-dxw