Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍝 refactor: deployment config (#118) #129

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

aahna-ashina
Copy link
Member

@aahna-ashina aahna-ashina commented Apr 29, 2024

Make usage and maintenance of deployment addresses easier.

Dework Task

Related GitHub Issue

close #118

How Has This Been Tested?

  • Status checks pass
  • Works on Goerli
  • Works on Sepolia
  • Works on Mainnet

Are There Admin Tasks?

@aahna-ashina aahna-ashina self-assigned this Apr 29, 2024
@aahna-ashina aahna-ashina marked this pull request as ready for review April 29, 2024 07:37
@aahna-ashina aahna-ashina requested a review from a team as a code owner April 29, 2024 07:37
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (a6e471f) to head (bb6d4d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files          14       14           
  Lines         272      272           
  Branches       52       53    +1     
=======================================
  Hits          244      244           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aahna-ashina aahna-ashina merged commit a3323a4 into main Apr 30, 2024
12 checks passed
@aahna-ashina aahna-ashina deleted the 118-deployment-config branch April 30, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put deployment addresses in config files
2 participants