Add Citizen profile page #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahna-ashina
commented
Nov 17, 2022
pages/profile/[ethAddress].tsx
Outdated
| colorGradient.addColorStop(1, 'rgba(213, 163, 152, 0.8)') | ||
|
|
||
| // Fetch data from datasets repo | ||
| const sourceCredFileUrl: string = `https://raw.githubusercontent.com/nation3/nationcred-datasets/f9e5b8d30b969815a918de619fa4e89a1c800ce3/data-sources/sourcecred/output/sourcecred-${profile.ethAddress}.csv` |
There was a problem hiding this comment.
@johnmark13 Using the data from your PR here. Once merged, we can update this URL.
johnmark13
previously approved these changes
Nov 17, 2022
@johnmark13 Yes, we can easily adjust the colors. Do you have suggestions for which colors to use? 😄 Also note that you can hover points in the chart to see details: |
|
@johnmark13 Added Dework chart: |
okhaimie-dev
previously approved these changes
Nov 18, 2022
@okhaimie-dev Great ideas! Added those here: |
|
Why the "Loading profile..." placeholder? |
|
@xPi2 Yes, a placeholder. Work in progress 😄 |
xPi2
previously approved these changes
Nov 18, 2022
luisivan
previously approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dework Task
https://app.dework.xyz/nation3/nationcred-p?taskId=246b633c-5075-4ba4-a6d1-e8e62bd96ffc
Screenshots