Reinstate Liquidity Rewards Program

[hhio618]

This will revert the changes made in commit 0d32b32#diff-c929e9424c96a55187bf3c7ecec95438b67f7a6f20df177e368728ba4bbe4890

Related GitHub Issue

#225

Screenshots (if appropriate):

How Has This Been Tested?

• Status checks pass (lint, build, test)
• Works on Sepolia preview deployment
• Works on Mainnet preview deployment

Are There Admin Tasks?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
citizen-app-mainnet	✅ Ready (Inspect)	Visit Preview	May 11, 2024 5:47am
citizen-app-sepolia	✅ Ready (Inspect)	Visit Preview	May 11, 2024 5:47am

[vercel]

@hhio618 is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.79%. Comparing base (110ad98) to head (f035479).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   11.79%   11.79%           
=======================================
  Files          18       18           
  Lines         356      356           
  Branches       80       77    -3     
=======================================
  Hits           42       42           
- Misses        308      314    +6     
+ Partials        6        0    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aahna-ashina]

@hhio618 I tested on the Mainnet preview: https://citizen-app-mainnet-git-fork-hhio618-main-nation3dao.vercel.app

On the /lock page, my $veNATION balance shows as 19.65:

But on the /liquidity page it shows as 0:

Any idea why the $veNATION balance is not loading?

[hhio618]

Please test using the latest commit.

[aahna-ashina]

@hhio618 I'm getting a division-by-zero error at https://citizen-app-sepolia-i57i145rj-nation3dao.vercel.app/liquidity

Is that because of the Reward APY being zero?

[hhio618]

@aahna-ashina I'm not sure! Please send me the testnet token so that I can test this further.
My eth address: 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605

[aahna-ashina]

Please send me the testnet token so that I can test this further.

@hhio618 Here is how to get testnet tokens: https://github.com/nation3/.github/blob/main/CONTRIBUTING.md

[hhio618]

@aahna-ashina Found the issue, the totalDeposit is zero in this contract: https://sepolia.etherscan.io/address/0x5514cF24D2241Ecc6012306927eA8d74E052416D#readContract. This value is being used for division in this code:

citizen-app/ui/lib/liquidity-rewards.ts

Line 75 in 833fc22

.div(poolValue.mul(totalDeposit).div(lpTokensSupply))

.

[aahna-ashina]

Found the issue, the totalDeposit is zero in this contract: https://sepolia.etherscan.io/address/0x5514cF24D2241Ecc6012306927eA8d74E052416D#readContract. This value is being used for division in this code:

citizen-app/ui/lib/liquidity-rewards.ts

Line 75 in 833fc22

.div(poolValue.mul(totalDeposit).div(lpTokensSupply))

.

@hhio618 Okay, thank you. So if we make a deposit, the error message should disappear?

[hhio618]

@aahna-ashina You're welcome! Yes, Just add tokens using the deposit method, which will do the trick!