Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revokeUnderBalance from config #229

Closed

Conversation

amochuko
Copy link
Contributor

@amochuko amochuko commented Jan 20, 2024

Dework Task

https://app.dework.xyz/nation3/open-bounties-95838?source=discord-dm&taskId=07770dc2-1903-4b46-8a94-70d408845e86

Related GitHub Issue

Remove nationPassportRevokeUnderBalance from config #226

Screenshots (if appropriate):

Screenshot 2024-01-20 at 05 24 06

How Has This Been Tested?

I got it tested locally while connected to the goerli testnet; here's the tx hash to the claim function: https://goerli.etherscan.io/tx/0x88ff2841554d3682eca66a539658a37a69a90984e7404953a6d77db452d6a4d0

@amochuko amochuko requested review from a team as code owners January 20, 2024 04:31
Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 4:32am

@amochuko amochuko changed the title Chuko remove revoke under balance Remove revokeUnderBalance from config Jan 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (410d849) 11.17% compared to head (1bbb1c9) 11.17%.

Files Patch % Lines
ui/lib/passport-expiration-hook.ts 0.00% 10 Missing and 1 partial ⚠️
ui/lib/config.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   11.17%   11.17%           
=======================================
  Files          18       18           
  Lines         349      349           
  Branches       78       78           
=======================================
  Hits           39       39           
  Misses        304      304           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aahna-ashina
Copy link
Member

Fixed in #227

@amochuko amochuko deleted the chuko-remove-revoke-under-balance branch May 16, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants