Skipping tracks on any NonStreamableError when getting downloadable info (#645) #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo (nathom#645) Based on the linked issue, also added check for fallback_id as it was empty and didn't result in a correct final error
|
I confirm that the problem I reported has been resolved. |
|
Looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping tracks on any NonStreamableError when getting downloadable info (#645)
Based on the linked issue, also added check for fallback_id as it was empty and didn't result in a correct final error.
I added the generic
NonStreamableErrorcatch as I think a track should be skipped on any reason for that exception, letting other possibly healthy tracks to be processed.The
WrongGeolocationDeezer exception from the linked album in the link affects only 2 tracks, so those cannot be downloaded. But others can.