Fix for [BUG] max() iterable argument is empty #677 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigologo
changed the title
nathom
requested changes
May 23, 2024
EllipPro
added a commit
to EllipPro/streamrip
that referenced
this pull request
Jun 12, 2024
Fix for [BUG] max() iterable argument is empty nathom#677 (nathom#683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #677
Cause seems to be missing "download info".
With that missing, that max check was breaking. Defaulting to 0 breaks downstream as there is still missing data. Halting flow seems like the best solution for a quick fix.
This is how it now displays during execution if download data is missing: