Object.seal sometime gets undefined value #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I see strange option `sockets` parameter which can be undefined if user didn't define it in `Vue` options. If I understand as right it may be bug. It can be related with this opened issue: nathantsoi#75 And the [Object.seal should get the object type](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/seal#Non-object_coercion). If it will be not object ES5 code will throw error. I didn't test it but i saw code and think that's should be patched.
Perlover
commented
Nov 13, 2020
weglov
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see strange the
socketsoption using which can be undefined if user didn't define it inVueoptions. If I understand as right it may be a bug.It can be related with this opened issue: #75
And the Object.seal should get the object type. If it will be not object the ES5 code will throw
TypeError. I didn't test it but i saw code and think that's should be patched.