Bug with DatePicker when inputting date range #1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanreyes |
|
@nathanreyes |
Merge in master updates
|
We can omit any additional type conversion (because we already have Date's instances from normalizeDate in this function) and only fix the logic instead. Thank you, Patrick! Waiting for fix either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using input elements to update the Date Picker a user can encounter a bug where a valid date range can be rejected and set to a singular day equal to the end date.
When entering a start date with a year less than that of the end date and a MM/dd later in the year than the end date, the input is treated as if it is greater than the end date. See the first video for examples using the v-calendar guide. The bug occurs when 10/17/2019 and 10/18/2019 are entered.
This is caused by the comparison of the dates as strings rather than as date objects. The second video shows the implemented fix has solved the problem.
Screen.Recording.2023-01-02.at.11.57.45.AM.mov
Screen.Recording.2023-01-02.at.10.51.39.PM.mov