Upated (the refactored) the "fill_container()" function to entirely fills the container with no distortion, using scale, center and 'crop' the edges around the container. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the 'fill_container()' to fill the container and crop around edges. There is no distortion anymore.
Refactored the logic, remove the modification in properties img_object.display[width|height]. The fill_container() now fills entirely the container by scaliing, centering and 'cropping' the image around the edges and provide interaction with filled image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the function fill_container fullfills the container, centering and cropping the image around the corners, provinding (almost) the same interaction like others zoom functions, eg: fit, with all combination of aspects (horizontal, vertical) of images.
It stills need some work, because i need to fix the fill_container() effect after rotate images and some functions, but the initial goal of the functions stills OK.