Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String#ljust spec-compliant #521

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Make String#ljust spec-compliant #521

merged 3 commits into from
Mar 4, 2022

Conversation

ryangjchandler
Copy link
Contributor

@ryangjchandler ryangjchandler commented Mar 3, 2022 •
edited
Loading

As per, some encoding specs are commented out.

I think once this is merged in, I'll open a separate PR that adds a to_str method on Object so that we can abstract some of the conversion code (used in String#center too and afterwards String#rjust).

#217

@ryangjchandler ryangjchandler mentioned this pull request Mar 3, 2022
Merged
@ryangjchandler
Copy link
Contributor Author

@seven1m Have updated this to use Object#to_str now.

@seven1m seven1m merged commit 6b107a3 into natalie-lang:master Mar 4, 2022
@ryangjchandler ryangjchandler deleted the feature/String#ljust branch March 4, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryangjchandler @seven1m