Add evaluate method to spec runner #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
changed the title
This is a combination of a dynamic eval and some tests wrapped in an `it` block. Since we do not support dynamic evals, we have to skip those. Adding this method removes the need to comment big chunks of the method spec, and this makes them show up as skipped tests.
herwinw
force-pushed
the
specs_runner_evaluate
branch
from
3fe1348
to
f293143
Compare
seven1m
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of a dynamic eval and some tests wrapped in an
itblock. Since we do not support dynamic evals, we have to skip those.Adding this method removes the need to comment big chunks of the method spec, and this makes them show up as skipped tests.