Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data north uganda 2016 #408

Merged
merged 13 commits into from
Aug 2, 2024
Merged

Conversation

yashgadhiya10
Copy link
Collaborator

No description provided.

@yashgadhiya10 yashgadhiya10 requested a review from MsPixels July 26, 2024 05:24
Copy link
Collaborator

@MsPixels MsPixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashgadhiya10
Copy link
Collaborator Author

yashgadhiya10 commented Jul 30, 2024

@ivanzvonkov Since the last few pull triggers, the count of data pulled is the same as reported in the report.txt. Also, some features were not pulled correctly. Needed your suggestion on how to fix the issue.

Update: Just checked that some missing features might be due to unavailability of Sentinal-2 data for our time frame (2016-01-01 to 2017-12-31)

@ivanzvonkov
Copy link
Collaborator

You're right there seems to be some issue with the S2 data
image

I ran openmapflow create-datasets locally which allows me to acknowledge failures in GEE and get around that.
There is still some test failures but they are from other causes, so this looks good to me.

@yashgadhiya10 yashgadhiya10 merged commit 0cd1b0c into master Aug 2, 2024
7 of 8 checks passed
@yashgadhiya10 yashgadhiya10 deleted the Add-data-North-Uganda-2016 branch August 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants